ensure there is no slicing risk on inherited classes#218
ensure there is no slicing risk on inherited classes#218atsju wants to merge 1 commit intogithubdoe:masterfrom
Conversation
|
I had to learn what "slicing" meant: Object slicing is a phenomenon in object-oriented programming, particularly in languages like C++, where an object of a derived class is assigned to a variable of its base class, resulting in the loss of the derived class's specific data and methods. Essentially, the "extra" parts of the derived class are "sliced off" during the assignment, leaving only the base class portion. This can lead to unexpected behavior and loss of functionality, as the derived class's unique attributes are no longer accessible. |
gr5
left a comment
gr5
left a comment
There was a problem hiding this comment.
These changes seem fine. I was able to build and run it just fine as well.
|
I don't remember much about those unused outline types. I might have thought they would be needed but then never did need them. If not used there is no plan to use them now by me so they can be removed as desired. |
|
Thank you both. I may do a second pull request and you can choose best option. |
|
I close this one. With latest information it seems what we want is #220 |
3 participants
Clazy the tool that checks some Qt and C++ compliance actually has level2 checks that I did not activate because 2Y ago we had 10k warnings on level1
I looked into clazy-copyable-polymorphic because this is a real risk.
What I mainly did is
boundaryan abstract class. Constructor, copy and move beingprotected, it cannot be instantiated. Thus no slicing is possible. Never.finaland removing some wrongvirtualis only to help Clazy identify there is no risk and remove the warning.To conclude: I can now confirm there was no slicing happening. The changes remove the risk to have it happen someday.
I choose the path of minimal changes to not mess with the code and simplify review. If you think
rectangleOutlineandellipseOutlinewill never be coded, we could simplify the code a lot. Remove inheritance and theses classes.I like the KISS principle "Keep It Short and Simple". Less code means less maintenance and less problems.
Kindly let me know if you prefer this pull request code with minimal changes or a more complete rewrite to simplify the code.